Some long-term savers prefer shares whilst others like investing in property. Tim Bennett weighs up the pros and cons of each.